Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(switches): add support for compiler switch with spaces #89

Merged
merged 3 commits into from
Mar 23, 2021

Conversation

jdhughes-usgs
Copy link
Collaborator

Added src_update for pgc7.f block that causes floating inexact errors on
macos with intel ifort compiler.

Added src_update for pgc7.f block that causes floating inexact errors on
macos with intel ifort compiler.
@codecov
Copy link

codecov bot commented Mar 22, 2021

Codecov Report

Merging #89 (2393768) into master (0137573) will decrease coverage by 0.31%.
The diff coverage is 70.96%.

❗ Current head 2393768 differs from pull request most recent head bce8a92. Consider uploading reports for the commit bce8a92 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master      #89      +/-   ##
==========================================
- Coverage   66.13%   65.82%   -0.32%     
==========================================
  Files          16       16              
  Lines        4034     4064      +30     
==========================================
+ Hits         2668     2675       +7     
- Misses       1366     1389      +23     
Impacted Files Coverage Δ
pymake/utils/_compiler_switches.py 80.71% <52.63%> (-1.53%) ⬇️
pymake/utils/_usgs_src_update.py 87.32% <100.00%> (-3.06%) ⬇️
pymake/pymake_base.py 87.65% <0.00%> (-0.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0137573...bce8a92. Read the comment docs.

Added src_update for pgc7.f block that causes floating inexact errors on
macos with intel ifort compiler.
Added src_update for pgc7.f block that causes floating inexact errors on
macos with intel ifort compiler.
@jdhughes-usgs jdhughes-usgs merged commit 887dc35 into modflowpy:master Mar 23, 2021
@jdhughes-usgs jdhughes-usgs deleted the flags-feat branch March 23, 2021 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant