Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/122/brew dependency updates #123

Merged
merged 2 commits into from
Jun 7, 2022

Conversation

defunctl
Copy link
Collaborator

@defunctl defunctl commented Jun 7, 2022

@dpellenwood If whomever was having problems with this can try this version of the installer before we merge, it should now work, let me know:

bash -c "$(curl -fsSL https://raw.githubusercontent.com/moderntribe/square1-global-docker/issue/122/brew-dependency-updates/install/install.sh)"

@defunctl defunctl requested a review from dpellenwood June 7, 2022 17:40
@defunctl defunctl self-assigned this Jun 7, 2022
Copy link
Contributor

@dpellenwood dpellenwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not able to test it b/c the script pulls the main branch version of package.txt which still contains the outdated brew packages. However, I think you're safe to merge anyway. I can test after the merge. Thanks @defunctl !

@defunctl
Copy link
Collaborator Author

defunctl commented Jun 7, 2022

@dpellenwood whoops, you're absolutely correct. Merging now.

@defunctl defunctl merged commit 9f480de into master Jun 7, 2022
@defunctl defunctl deleted the issue/122/brew-dependency-updates branch June 7, 2022 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install script fails to install requirements on Mac due to changed homebrew formulas
2 participants