Allow Moneta::Expires as cache object to allow for non-native expiring caches #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. I'll review. |
|
@GrahamW, is there a way you can write a test for this? (under the tests folder). Thanks |
|
Yeah - I'll have a think about the best way to do that. |
apersaud
added a commit
that referenced
this pull request
Aug 13, 2017
Allow Moneta::Expires as cache object to allow for non-native expiring caches
apersaud
added a commit
that referenced
this pull request
Aug 13, 2017
Allow Moneta::Expires as cache object to allow for non-native expiring caches
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small change to allow use of Moneta::Expires proxy when not using an adaptor with native expiry.
Could have changed the check for Moneta::Transformer to also check for Moneta::Expires too, but now checking for the methods used being present. Think this is OK?