refactor: Common static analysis issues

Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.staticanalysis.CommonStaticAnalysis?organizationId=TW9kZXJuZQ%3D%3D Co-authored-by: Moderne <[email protected]>
moderneinc · Apr 18, 2024 · d80df68 · d80df68
1 parent f7ebc7e
commit d80df68
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/main/java/com/yourorg/SimplifyTernary.java b/src/main/java/com/yourorg/SimplifyTernary.java
@@ -56,7 +56,7 @@ boolean before(boolean expr) {
         @AfterTemplate
         boolean after(boolean expr) {
             // We wrap the expression in parentheses as the input expression might be a complex expression
-            return !(expr);
+            return !expr;
         }
     }
 }
diff --git a/src/main/java/com/yourorg/UpdateConcoursePipeline.java b/src/main/java/com/yourorg/UpdateConcoursePipeline.java
@@ -51,7 +51,7 @@ public TreeVisitor<?, ExecutionContext> getVisitor() {
                     @Override
                     public Yaml.Mapping.Entry visitMappingEntry(Yaml.Mapping.Entry entry, ExecutionContext ctx) {
                         Yaml.Mapping.Entry e = super.visitMappingEntry(entry, ctx);
-                        if (e.getKey().getValue().equals("source")) {
+                        if ("source".equals(e.getKey().getValue())) {
                             Yaml.Block value = e.getValue();
                             if (!(value instanceof Yaml.Mapping)) {
                                 return e;