Add a note about the use of the guava classpath entry

moderneinc · May 11, 2024 · d188728 · d188728
1 parent fad2033
commit d188728
Showing 1 changed file with 14 additions and 13 deletions.
diff --git a/src/test/java/com/yourorg/NoGuavaListsNewArrayListTest.java b/src/test/java/com/yourorg/NoGuavaListsNewArrayListTest.java
@@ -35,6 +35,7 @@ public void defaults(RecipeSpec spec) {
         spec.recipe(new NoGuavaListsNewArrayList())
           .parser(JavaParser.fromJavaVersion()
             .logCompilationWarningsAndErrors(true)
+            // The before/after examples are using Guava classes, so we need to add the Guava library to the classpath
             .classpath("guava"));
     }
 
@@ -52,17 +53,17 @@ void replaceWithNewArrayList() {
           java(
             """
               import com.google.common.collect.*;
-                            
+              
               import java.util.List;
-                            
+              
               class Test {
                   List<Integer> cardinalsWorldSeries = Lists.newArrayList();
               }
               """,
             """
               import java.util.ArrayList;
               import java.util.List;
-                            
+              
               class Test {
                   List<Integer> cardinalsWorldSeries = new ArrayList<>();
               }
@@ -78,10 +79,10 @@ void replaceWithNewArrayListIterable() {
           java(
             """
               import com.google.common.collect.*;
-                            
+              
               import java.util.Collections;
               import java.util.List;
-                            
+              
               class Test {
                   List<Integer> l = Collections.emptyList();
                   List<Integer> cardinalsWorldSeries = Lists.newArrayList(l);
@@ -91,7 +92,7 @@ class Test {
               import java.util.ArrayList;
               import java.util.Collections;
               import java.util.List;
-                            
+              
               class Test {
                   List<Integer> l = Collections.emptyList();
                   List<Integer> cardinalsWorldSeries = new ArrayList<>(l);
@@ -108,18 +109,18 @@ void replaceWithNewArrayListWithCapacity() {
           java(
             """
               import com.google.common.collect.*;
-                            
+              
               import java.util.ArrayList;
               import java.util.List;
-                            
+              
               class Test {
                   List<Integer> cardinalsWorldSeries = Lists.newArrayListWithCapacity(2);
               }
               """,
             """
               import java.util.ArrayList;
               import java.util.List;
-                            
+              
               class Test {
                   List<Integer> cardinalsWorldSeries = new ArrayList<>(2);
               }
@@ -135,10 +136,10 @@ void showNeedForSuperVisitMethodInvocation() {
           java(
             """
               import com.google.common.collect.*;
-                            
+              
               import java.util.Collections;
               import java.util.List;
-                            
+              
               class Test {
                   List<Integer> cardinalsWorldSeries = Collections.unmodifiableList(Lists.newArrayList());
               }
@@ -147,7 +148,7 @@ class Test {
               import java.util.ArrayList;
               import java.util.Collections;
               import java.util.List;
-                            
+              
               class Test {
                   List<Integer> cardinalsWorldSeries = Collections.unmodifiableList(new ArrayList<>());
               }
@@ -167,7 +168,7 @@ void noChangeNecessary() {
               import java.util.ArrayList;
               import java.util.Collections;
               import java.util.List;
-                            
+              
               class Test {
                   List<Integer> cardinalsWorldSeries = Collections.unmodifiableList(new ArrayList<>());
               }