changed .getsize to .getlength for compatibility with Pillow 10 #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericmjl
deleted the
77-attributeerror-freetypefont-object-has-no-attribute-getsize-pillow-10
branch
GitBot Summary of ChangesThe pull request includes changes in the draw_alignment function in the seqlike/draw_utils.py file. The changes involve replacing the 'getsize' method with 'getlength' for calculating the length of the maximum string in the 'name', 'id', and 'description' fields of the 'aligned' object. The result is then converted to an integer before being added to the 'offset'. This change has been made for the conditions when 'show_names', 'show_ids', and 'show_descriptions' are true. cc: @ndousis, please check for correctness! |
|
@ndousis I'm going to cut a new release now. This should be a patch release IMO. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #77 by changing
font.getizetofont.getlengthin thedraw_alignmentmethod.All tests pass.