Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved documentation for singleton provider and minor fixes #92

Merged
merged 13 commits into from
Sep 29, 2024
Merged

Improved documentation for singleton provider and minor fixes #92

merged 13 commits into from
Sep 29, 2024

Conversation

alexanderlazarev0
Copy link
Collaborator

@alexanderlazarev0 alexanderlazarev0 commented Sep 28, 2024

  • Moved the _override attribute in AbstractProvider into it's __init__ method since before it was only created when calling override().
  • Written some extra doc-strings.
  • Rewritten the Singleton documentation for clarity and to provide a more in-detail example.

@alexanderlazarev0
Copy link
Collaborator Author

alexanderlazarev0 commented Sep 28, 2024

@lesnik512 Annoying that my old commits are still showing up, next time I will just make a new fork ...
Diff is correct though.

@alexanderlazarev0 alexanderlazarev0 added documentation Improvements or additions to documentation enhancement New feature or request labels Sep 28, 2024
that_depends/providers/base.py Outdated Show resolved Hide resolved
.pre-commit-config.yaml Outdated Show resolved Hide resolved
@lesnik512 lesnik512 merged commit 4704255 into modern-python:main Sep 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants