fix varioius type hinting issues #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veriff-saulvargas
force-pushed
the
type-checking-improvements
branch
from
95ac821 to
61bcdaf
Compare
veriff-saulvargas
force-pushed
the
type-checking-improvements
branch
from
61bcdaf to
8c94a79
Compare
|
Hi, thank you for the fixes! I'm looking into it |
|
1.7.1 is published with this PR https://pypi.org/project/that-depends/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I discovered this project this week, and I am currently considering it as a replacement to
dependency-injector. Thank you for creating it.This PR contains type hinting fixes for some issues that I have detected while testing
that-dependson my codebase, running bothmypyandpyright. Please read the inline comments for more details and let me know what you think.