fix for provider overriding in litestar #120
Conversation
lesnik512
force-pushed
the
119-bug-provider-overriding-does-not-works-with-litestar
branch
from
d70db4e to
b79c9e8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Flags with carried forward coverage won't be shown. Click here to find out more.
🚨 Try these New Features:
|
|
@nightblure It can be fixed by forbidding deepcopy of providers. Seems like litestar doing deepcopy of router or sth like that |
|
@vrslev @alexanderlazarev0 Hi! What do you think? Is it safe to redefine deepcopy method to forbid providers cloning? P.S. there is a problem with overriding in Litestar and I find out, that object in |
|
Actually, I encountered this exact issue recently)
I guess so, I don’t see any potential issues with it in our context. |
lesnik512
deleted the
119-bug-provider-overriding-does-not-works-with-litestar
branch
| @@ -22,6 +24,9 @@ def __init__(self) -> None: | |||
| super().__init__() | |||
| self._override: typing.Any = None | |||
|
|
|||
| def __deepcopy__(self, *_: object, **__: object) -> typing_extensions.Self: | |||
There was a problem hiding this comment.
I think very good decision will be to left here comment with reference to issue and reference to litestar behaviour. Because at some point it may be not so easy to understand why this decision is been made
No description provided.