Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update mapiterinit to reflect changes in go1.18 reflect #24

Closed
cuonglm opened this issue Sep 8, 2021 · 1 comment · Fixed by #25
Closed

Update mapiterinit to reflect changes in go1.18 reflect #24

cuonglm opened this issue Sep 8, 2021 · 1 comment · Fixed by #25

Comments

@cuonglm
Copy link

cuonglm commented Sep 8, 2021

The commit: golang/go@1b2d794

was landed, so reflect.mapiterinit will change in go1.18.

See also: golang/go#48238
@ianlancetaylor ianlancetaylor mentioned this issue Sep 9, 2021
Closed
@taowen
Copy link
Contributor

taowen commented Sep 10, 2021

anyone can help to maintain https://github.com/modern-go/reflect2 ? I no longer have the insight to keep up with the language evolution.

@taowen taowen mentioned this issue Sep 11, 2021
Merged
@mkumatag mkumatag mentioned this issue Sep 13, 2021
Closed
4 tasks
@risentveber risentveber mentioned this issue Aug 24, 2022
Closed
This was referenced Jan 3, 2024
Open
Merged
emicklei pushed a commit to emicklei/go-restful that referenced this issue Jan 3, 2024
@dominiquelefevre
remove the dependency on github.com/json-iterator/go. (#539)
290805f 
That module uses github.com/modern-go/reflect2 which is broken.

First, it is brittle because it relies on golang's implementation
details that are not stable across golang releases. For example,
reflect2 was broken when go 1.18 came out.

Second, reflect2 is effectively unmaintained:
  modern-go/reflect2#24 (comment)

Json-iterator itself has had correctness issues like
  json-iterator/go#413.

The Kubernetes project has mostly removed the dependency on json-iterator
in patches like
  kubernetes/kubernetes#105030.

Moreover, the Kubernetes authors found it out that json-iterator puts
a lot of load on the allocator, so even the performance gains are
questionable.

Let us remove dependencies on json-iterator and reflect2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WIP: update signature of mapiterinit of go 1.18 modern-go/reflect2
2 participants
@taowen @cuonglm