include the missing cpp2regex.h in cpp2util target #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is incorporated in #165 already -- but there's a test failure I didn't have a chance to diagnose. Do you know anything about that? |
|
@alexreinking Trying here with the official 0.7.2 release commit for the submodule instead of the latest |
|
Oh, he's doing actual releases now? That works for me. |
|
I'm going to start from here and try to fix the tests. Thanks for helping out! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the required
cpp2regex.his not getting installed and the example cannot be built.Changes:
cpp2regex.hfor the targetcpp2util.Tested on Ubuntu 24.04 with
cmake3.30.1.