Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/preparation for wheel & Docker #23

Merged
merged 5 commits into from
Sep 18, 2023
Merged

Feature/preparation for wheel & Docker #23

merged 5 commits into from
Sep 18, 2023

Conversation

HYLcool
Copy link
Collaborator

@HYLcool HYLcool commented Sep 18, 2023

  • For wheel packaging:
    • To package a wheel package that satisfies the requirements of PyPi, we remove or replace those dependencies from URLs (kenlm and some models from spacy)
    • Add more invoking methods for tools/process_data.py and tools/analyze_data.py:
      • python -m data_juicer.tools.process_data and python -m data_juicer.tools.analyze_data for pip installation
      • dj-process and dj-analyze command line tools
  • For Docker:
    • Add a Dockerfile for building the docker image of data-juicer
  • Others:
    • Set the default value of count threshold to 0 in the main app.py for issue What causes visualization to be blank? #22
    • Add missing default arguments to configs/config_all.yaml from distributed processing
    • Replace images used in README with URLs.

@HYLcool HYLcool added the enhancement New feature or request label Sep 18, 2023
Copy link
Collaborator

@yxdyc yxdyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yxdyc yxdyc merged commit b8f21c9 into main Sep 18, 2023
1 check passed
@HYLcool HYLcool deleted the feature/whl_pkg branch September 19, 2023 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants