Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added the generated_caption_mapper #131

Merged
merged 12 commits into from
Jan 11, 2024
Merged

added the generated_caption_mapper #131

merged 12 commits into from
Jan 11, 2024

Conversation

yxdyc
Copy link
Collaborator

@yxdyc yxdyc commented Dec 12, 2023

as the title says, related feature request issue #116

@yxdyc yxdyc added enhancement New feature or request dj:multimodal issues/PRs about multimodal data processing labels Dec 12, 2023
@yxdyc yxdyc added this to the Multimodal Support milestone Dec 12, 2023
@yxdyc yxdyc self-assigned this Dec 12, 2023
@yxdyc
Copy link
Collaborator Author

yxdyc commented Jan 2, 2024

Thanks @zhijianma 's comments! I have modified the codes accordingly, see this commit.

@zhijianma zhijianma self-requested a review January 3, 2024 01:58
@yxdyc yxdyc linked an issue Jan 3, 2024 that may be closed by this pull request
[MM] add a Mapper to generate captions based on models #116
Closed
@HYLcool HYLcool added the dj:op issues/PRs about some specific OPs label Jan 8, 2024
@yxdyc
Copy link
Collaborator Author

yxdyc commented Jan 9, 2024

Thanks for @HYLcool 's comments. I couldn't spare the time to fix and test these comments within the last few days. Please help me to continue developing this OP.

@HYLcool
Copy link
Collaborator

HYLcool commented Jan 9, 2024 •
edited
Loading

The Huggingface model Salesforce/blip2-opt-2.7b is too large (> 15.5GB). The runner provided by GitHub has only 14GB of disk space. So we decide to test this new OP locally and skip unit tests of it in the GitHub Action. @yxdyc @chenhesen

  • local tests for generate_caption_mapper passed

@HYLcool HYLcool self-assigned this Jan 10, 2024
@HYLcool
* fix diversity problems
16ed616 
* doc modifications
@HYLcool
Copy link
Collaborator

HYLcool commented Jan 10, 2024 •
edited
Loading

This OP has passed the local tests. Online unit tests on GitHub for this OP are skipped. Please continue to review the latest commits by me. Thanks. @zhijianma @chenhesen

chenhesen
chenhesen approved these changes Jan 11, 2024
View reviewed changes
Copy link
Collaborator

@chenhesen chenhesen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool

@HYLcool HYLcool merged commit 2588004 into main Jan 11, 2024
5 checks passed
@HYLcool HYLcool deleted the feat/generate_caption_mapper branch January 11, 2024 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HYLcool HYLcool HYLcool left review comments

@chenhesen chenhesen chenhesen approved these changes

@zhijianma zhijianma Awaiting requested review from zhijianma

Assignees

@HYLcool HYLcool

@yxdyc yxdyc

Labels
dj:multimodal issues/PRs about multimodal data processing dj:op issues/PRs about some specific OPs enhancement New feature or request
Projects
None yet
Milestone
Basic Multimodal Support
Development

Successfully merging this pull request may close these issues.

[MM] add a Mapper to generate captions based on models
4 participants
@yxdyc @HYLcool @chenhesen @zhijianma