forked from rust-lang/rust
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a few intrinsics contracts #37
Open
celinval
wants to merge
11
commits into
model-checking:main
Choose a base branch
from
celinval:verify-intrinsics
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
celinval
force-pushed
the
verify-intrinsics
branch
from
July 17, 2024 19:53
c6f96e3
to
ee88552
Compare
- This is not working due to a Kani limitation
The intrinsics `copy` and `copy_nonoverlapping` are untyped copies, so they don't respect the validity requirements of `T`.
is this waiting for something? |
Yes, I need to update the branch and tests. |
# Conflicts: # library/core/src/intrinsics.rs
celinval
force-pushed
the
verify-intrinsics
branch
from
September 19, 2024 22:33
15086ea
to
b2eaef8
Compare
celinval
force-pushed
the
verify-intrinsics
branch
from
September 19, 2024 22:35
b2eaef8
to
87dc890
Compare
celinval
force-pushed
the
verify-intrinsics
branch
from
September 20, 2024 01:29
6827756
to
a38c161
Compare
FYI, this is blocked until we merge the PointerGenerator into Kani: model-checking/kani#3538 |
celinval
force-pushed
the
verify-intrinsics
branch
from
October 16, 2024 23:41
d41e5c1
to
18b61ff
Compare
celinval
force-pushed
the
verify-intrinsics
branch
from
October 16, 2024 23:44
fbc8c69
to
24495a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are a few problems that I bumped into:
write_bytes
,copy
andcopy_nonoverlapping
.modifies
clauses kani#2908.__CPROVER_is_fresh
would be sound. From the documentation, it sounds like it will allocate fresh memory for each pointer. However, we would also like to cover the case where these pointers overlap.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.