Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade toolchain to 2024-04-22 #3171

Merged
merged 16 commits into from
May 14, 2024
Merged

Upgrade toolchain to 2024-04-22 #3171

merged 16 commits into from
May 14, 2024

Conversation

zhassan-aws
Copy link
Contributor

Addresses the new AggregateKind::RawPtr added in rust-lang/rust#123840.

Resolves #3161

Keeping it a draft because some of the regressions are failing.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@github-actions github-actions bot added the Z-BenchCI Tag a PR to run benchmark CI label May 4, 2024
@zhassan-aws zhassan-aws mentioned this pull request May 4, 2024
Closed
@tautschnig
Copy link
Member

Briefly chatting with @zhassan-aws about this: quite likely we'll want to refactor some existing code, but at least our combined patches now make tests pass.

@zhassan-aws
Copy link
Contributor Author

Thanks @tautschnig! Updating the PR to "Ready for review".

@zhassan-aws zhassan-aws marked this pull request as ready for review May 10, 2024 16:44
@zhassan-aws zhassan-aws requested a review from a team as a code owner May 10, 2024 16:44
adpaco-aws
adpaco-aws reviewed May 10, 2024
View reviewed changes
Copy link
Contributor

@adpaco-aws adpaco-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @zhassan-aws and @tautschnig for your help! Agree that the code could use some refactoring but we can do that later.

@karkhaz do you know why benchcomp might be crashing in this case?

@zhassan-aws
Copy link
Contributor Author

Weird: when I deleted the non-failing perf tests to speed up the benchcomp run and simplify the debugging, the failing test (perf/vec/vec) no longer failed!

@zhassan-aws
Copy link
Contributor Author

The spurious benchcomp failures seem to be gone as the last several runs completed successfully. The regressions with a slowdown are two of the usual contenders (random::tests::gen_range_biased_test and vectored_copy_fuzz_test), so no blockers.

karkhaz
karkhaz suggested changes May 14, 2024
View reviewed changes
.github/workflows/bench.yml Outdated Show resolved Hide resolved
@zhassan-aws zhassan-aws merged commit 997a54c into model-checking:main May 14, 2024
22 of 23 checks passed
@zhassan-aws zhassan-aws deleted the toolchain-2024-04-22 branch May 14, 2024 17:51
tautschnig added a commit to tautschnig/kani that referenced this pull request Jun 4, 2024
@tautschnig
Bump Kani version to 0.52.0
fb87e39 
Updated version in all `Cargo.toml` files (via `find . -name Cargo.toml -exec
sed -i 's/version = "0.51.0"/version = "0.52.0"/' {} \;`) and ran `cargo
build-dev` to have `Cargo.lock` files updated.

GitHub generated release notes:

 ## What's Changed
* Bump tests/perf/s2n-quic from `6dd41e0` to `bd37960` by @dependabot in model-checking#3178
* Automatic cargo update to 2024-05-13 by @github-actions in model-checking#3177
* Upgrade toolchain to 2024-04-22 by @zhassan-aws in model-checking#3171
* Upgrade toolchain to 2024-05-14 by @zhassan-aws in model-checking#3183
* Automatic toolchain upgrade to nightly-2024-05-15 by @github-actions in model-checking#3185
* Include `--check-cfg=cfg(kani)` in the rust flags to avoid a warning about an unknown `cfg`. by @zhassan-aws in model-checking#3187
* Automatic toolchain upgrade to nightly-2024-05-16 by @github-actions in model-checking#3189
* Perform cargo update because of yanked libc version by @zhassan-aws in model-checking#3192
* Automatic toolchain upgrade to nightly-2024-05-17 by @github-actions in model-checking#3191
* Automatic cargo update to 2024-05-20 by @github-actions in model-checking#3195
* Bump tests/perf/s2n-quic from `bd37960` to `f5d9d74` by @dependabot in model-checking#3196
* New section about linter configuraton checking in the doc. by @remi-delmas-3000 in model-checking#3198
* Automatic cargo update to 2024-05-27 by @github-actions in model-checking#3201
* Bump tests/perf/s2n-quic from `f5d9d74` to `d03cc47` by @dependabot in model-checking#3202
* Update Rust toolchain from nightly-2024-05-17 to nightly-2024-05-23 by @remi-delmas-3000 in model-checking#3199
* Fix `{,e}println!()` by @GrigorenkoPV in model-checking#3209
* Contracts for a few core functions by @celinval in model-checking#3107
* Don't crash benchcomp when rounding non-numeric values by @karkhaz in model-checking#3211
* Update Rust toolchain nightly-2024-05-24 by @qinheping in model-checking#3212
* Upgrade Rust toolchain nightly-2024-05-27  by @qinheping in model-checking#3215
* Automatic toolchain upgrade to nightly-2024-05-28 by @github-actions in model-checking#3217
* Automatic cargo update to 2024-06-03 by @github-actions in model-checking#3220
* Bump tests/perf/s2n-quic from `d03cc47` to `d90729d` by @dependabot in model-checking#3222
* Add simple API for shadow memory by @zhassan-aws in model-checking#3200

 ## New Contributors
* @GrigorenkoPV made their first contribution in model-checking#3209

**Full Changelog**: model-checking/kani@kani-0.51.0...kani-0.52.0
@tautschnig tautschnig mentioned this pull request Jun 4, 2024
Merged
tautschnig added a commit that referenced this pull request Jun 4, 2024
@tautschnig
Bump Kani version to 0.52.0 (#3224)
358ade9 
Updated version in all `Cargo.toml` files (via `find . -name Cargo.toml
-exec sed -i 's/version = "0.51.0"/version = "0.52.0"/' {} \;`) and ran
`cargo build-dev` to have `Cargo.lock` files updated.

GitHub generated release notes:

 ## What's Changed
* Bump tests/perf/s2n-quic from `6dd41e0` to `bd37960` by @dependabot in
#3178
* Automatic cargo update to 2024-05-13 by @github-actions in
#3177
* Upgrade toolchain to 2024-04-22 by @zhassan-aws in
#3171
* Upgrade toolchain to 2024-05-14 by @zhassan-aws in
#3183
* Automatic toolchain upgrade to nightly-2024-05-15 by @github-actions
in #3185
* Include `--check-cfg=cfg(kani)` in the rust flags to avoid a warning
about an unknown `cfg`. by @zhassan-aws in
#3187
* Automatic toolchain upgrade to nightly-2024-05-16 by @github-actions
in #3189
* Perform cargo update because of yanked libc version by @zhassan-aws in
#3192
* Automatic toolchain upgrade to nightly-2024-05-17 by @github-actions
in #3191
* Automatic cargo update to 2024-05-20 by @github-actions in
#3195
* Bump tests/perf/s2n-quic from `bd37960` to `f5d9d74` by @dependabot in
#3196
* New section about linter configuraton checking in the doc. by
@remi-delmas-3000 in #3198
* Automatic cargo update to 2024-05-27 by @github-actions in
#3201
* Bump tests/perf/s2n-quic from `f5d9d74` to `d03cc47` by @dependabot in
#3202
* Update Rust toolchain from nightly-2024-05-17 to nightly-2024-05-23 by
@remi-delmas-3000 in #3199
* Fix `{,e}println!()` by @GrigorenkoPV in
#3209
* Contracts for a few core functions by @celinval in
#3107
* Don't crash benchcomp when rounding non-numeric values by @karkhaz in
#3211
* Update Rust toolchain nightly-2024-05-24 by @qinheping in
#3212
* Upgrade Rust toolchain nightly-2024-05-27 by @qinheping in
#3215
* Automatic toolchain upgrade to nightly-2024-05-28 by @github-actions
in #3217
* Automatic cargo update to 2024-06-03 by @github-actions in
#3220
* Bump tests/perf/s2n-quic from `d03cc47` to `d90729d` by @dependabot in
#3222
* Add simple API for shadow memory by @zhassan-aws in
#3200

 ## New Contributors
* @GrigorenkoPV made their first contribution in
#3209

**Full Changelog**:
kani-0.51.0...kani-0.52.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adpaco-aws adpaco-aws adpaco-aws approved these changes

@karkhaz karkhaz karkhaz approved these changes

Assignees
No one assigned
Labels
Z-BenchCI Tag a PR to run benchmark CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Toolchain upgrade to nightly-2024-04-22 failed
4 participants
@zhassan-aws @tautschnig @karkhaz @adpaco-aws