Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolchain upgrade to nightly-2024-10-29 failed #3657

Closed
github-actions bot opened this issue Oct 29, 2024 · 2 comments · Fixed by #3658
Closed

Toolchain upgrade to nightly-2024-10-29 failed #3657

github-actions bot opened this issue Oct 29, 2024 · 2 comments · Fixed by #3658

Comments

@github-actions
Copy link
Contributor

Updating Rust toolchain from nightly-2024-10-28 to nightly-2024-10-29 requires source changes.
The failed automated run can be found here.
Please review the changes at https://github.com/rust-lang/rust from rust-lang/rust@df4ca44 up to rust-lang/rust@3f1be1e. The log for this commit range is:
rust-lang/rust@3f1be1ec7e Auto merge of #132145 - RalfJung:stdarch, r=Amanieu
rust-lang/rust@9f57edf2e2 Auto merge of #132262 - matthiaskrgr:rollup-pcphi6l, r=matthiaskrgr
rust-lang/rust@2ca9b2cddd Rollup merge of #132253 - Zalathar:keyword-idents-bug, r=jieyouxu
rust-lang/rust@a4acbd561b Rollup merge of #132252 - workingjubilee:rename-layouts-to-layoutdata, r=jieyouxu
rust-lang/rust@f62ed5eb57 Rollup merge of #132248 - workingjubilee:add-rustc-abi-to-transmute, r=compiler-errors
rust-lang/rust@81d885b933 Rollup merge of #131391 - ChaiTRex:isqrt, r=scottmcm,tgross35
rust-lang/rust@d066dfdb83 we can now enable the 'const stable fn must be stable' check
rust-lang/rust@32b17d56eb Auto merge of #132244 - jyn514:linker-refactors, r=bjorn3
rust-lang/rust@f370f3493d bump stdarch
rust-lang/rust@66701c4226 Auto merge of #132251 - jieyouxu:rollup-mtv9mpd, r=jieyouxu
rust-lang/rust@dfafbc41d8 Known-bug test for keyword_idents lint not propagating to other files
rust-lang/rust@3e3feac7c3 Rollup merge of #132243 - compiler-errors:no-span, r=jieyouxu
rust-lang/rust@f14637b025 Rollup merge of #132242 - ultrabear:const_is_digit, r=scottmcm
rust-lang/rust@a9ee1d025b Rollup merge of #132227 - compiler-errors:better-const-span, r=Nadrieril
rust-lang/rust@afc93a9128 Rollup merge of #132225 - clubby789:run-make-dynamic, r=jieyouxu
rust-lang/rust@5c14e3d54c Rollup merge of #132220 - GuillaumeGomez:gui-test-struct-fields-margins, r=notriddle
rust-lang/rust@20d2a546fa Rollup merge of #132086 - estebank:long-types, r=jieyouxu
rust-lang/rust@95a9d496f3 Rollup merge of #131633 - asquared31415:align_isize_max, r=jieyouxu
rust-lang/rust@2a9239a105 rust-analyzer: Rename LayoutS to LayoutData
rust-lang/rust@9015c6deca cg_clif: Rename LayoutS to LayoutData
rust-lang/rust@e1781297f3 compiler: Rename LayoutS to LayoutData
rust-lang/rust@6fc7ce43d2 Error on alignments greater than isize::MAX
rust-lang/rust@6929a48275 Auto merge of #132200 - Mark-Simulacrum:strengthen-cross-lang, r=RalfJung
rust-lang/rust@27207069d8 rustc_transmute: Directly use types from rustc_abi
rust-lang/rust@675f447d88 don't pass -L .../auxiliary unless it exists
rust-lang/rust@f1e5b365f0 port tests/ui/linkage-attr/framework to run-make
rust-lang/rust@3141a65d25 give a better error for tuple structs in derive(Diagnostic)
rust-lang/rust@d792e1f50a remove dead code in CGREP script
rust-lang/rust@7f54b9ecef Remove ObligationCause::span() method
rust-lang/rust@2507e83d7b Stop using the whole match expr span for an arm's obligation span
rust-lang/rust@66209cd9b5 Support char::is_digit in const contexts
rust-lang/rust@9bb6e0789c Dynamically link run-make support
rust-lang/rust@c50bfda34f Add GUI regression test for doc struct fields margins
rust-lang/rust@c1a08f9763 Make clearer that guarantees in ABI compatibility are for Rust only
rust-lang/rust@bd95695b94 Pass constness with span into lower_poly_trait_ref
rust-lang/rust@5980a32ef1 Pass long type path into note_obligation_cause_code to avoid printing same path multiple times
rust-lang/rust@aa82fd6d1d Tweak highlighting when trait is available for different type
rust-lang/rust@24ac777a64 Add test for #132013
rust-lang/rust@f954bab4f1 Stabilize isqrt feature

@tautschnig
Copy link
Member

Looks like this upstream PR is the culprit: rust-lang/rust#132252 - we should just need to replace LayoutS by LayoutData.

@zhassan-aws
Copy link
Contributor

Thanks @tautschnig!

github-merge-queue bot pushed a commit that referenced this issue Oct 29, 2024
Culprit PR identified by @tautschnig:
rust-lang/rust#132252

Resolves #3657 

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 and MIT licenses.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants