-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invalid stub cause different ICE while monomorphizing the code #2589
Comments
celinval
changed the title
Invalid stub cause ICE: Unexpected polymorphic constant
Invalid stub cause different ICE while monomorphizing the code
Jul 7, 2023
BTW, this happens because BTW, I think the best solution here is to find a better error handling for stub trait resolution instead of adding extra checks to the reachability algorithm. In theory, any place where we monomorphize an item, it can fail. Here is another example: fn original<T>() {}
trait Dummy {
fn true_val() -> bool {
true
}
}
fn stub<T: Dummy>() {
// Do nothing.
assert!(T::true_val())
}
#[kani::proof]
#[kani::stub(original, stub)]
fn check_mismatch() {
original::<String>();
} Stack backtrack
|
celinval
added a commit
that referenced
this issue
Nov 30, 2023
Rewrite the reachability module to use Stable APIs wherever possible. Note that in StableMIR the instance body is already monomorphized and constants are already evaluated, which simplifies the code for most of it, except to handle stubbing issue #2589. For the stubbing issue, we still use a mix of stable and internal APIs to detect an invalid monomorphization. Co-authored-by: Adrian Palacios <[email protected]> Co-authored-by: Zyad Hassan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I tried this code:
using the following command line invocation:
with Kani version: 0.31.0 (dev)
I expected to see this happen: Kani should print a trait mismatch error
Instead, this happened: Kani compiler crashed with the following error:
Stack backtrace
The text was updated successfully, but these errors were encountered: