Replace expensive count() with cheap exists() #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuky
changed the title
|
Thx. Yeah, it's especially an improvement for MySQL InnoDB like we run 😏 |
|
@tuky great catch here! Thanks for the contribution! |
amureki
added a commit
that referenced
this pull request
Aug 9, 2024
* origin/main: Bump 1.19.0 Fix #483 -- Add Django 5.1 support (#485) Bump 1.18.3 Refs #416 -- Allow combination of GFK and `_fill_optional` (#438) Bump 1.18.2 Update ruff CI syntax (#481) Fix #28 -- allow make_recipe to work with _quantity (#480) Bump 1.18.1 Replace expensive `count()` with cheap `exists()` (#478) Update CI Python version to 3.12 Delete hard action requirement for a changelog Bump 1.18.0 Fix #265 -- drop hard dependency on `contenttypes` framework (#476) Bump GitHub Actions artifacts to v4 (#470) Drop Django 3.2 support (#475) Bump actions/setup-python from 4 to 5 (#466) Drop Django 4.1 support (reached end of life) (#465) Support Django 5.0 (#464)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heyo, hopefully an easy one. We are using model bakery in a setting where the DB can have millions of rows and counting the table just for checking, if any entry exists is overkill. The easy solution: only check for existence.