Fixes #3237: Fix NullPointerException in Only.verify #3349
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In the latest version of mockito-core (5.9.0), the
Only.verify
method throws aNullPointerException
when it attempts to callReporter.noMoreInteractionsWanted
with a null argument. This occurs because the methodInvocationsFinder.findFirstUnverified
can return null, but this is not handled properly inOnly.verify
.This fixes #3237
Changes
InvocationsFinder.findFirstUnverified
inOnly.verify
. If the result is null,Reporter.noMoreInteractionsWanted
is not called.Checklist
including project members to get a better picture of the change
commit is meaningful and help the people that will explore a change in 2 years
Fixes #<issue number>
in the description if relevantFixes #<issue number>
if relevant