Reduce warnings during build, in IDE and in GitHub UI #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TWiStErRob
changed the title
Fixes: w: Parameter 'kClass' is never used
… Mockito 4.6 Fixes: 'lenient(): MockSettings!' is deprecated. Deprecated in Java
spy() always returns an object be it nullable or not. Fixes: w: Unnecessary non-null assertion (!!) on a non-null receiver of type T
(double-spaces, missing spaces, and new line at end of file)
|
@TimvdLippe rebased to resolve conflict, ready for review. Recommended commit by commit, only the last one has a lot of (whitespace) changes, the rest are tiny. |
|
This looks good to me, do you mind rebasing again as I just merged your other PR? |
|
Merged in and resolved the conflict |
|
(Merge shows what changes more trivially than rebase, if you open it on GH) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting a pull request! But first:
Existing tests should cover everything, most changes in this PR are only for human readers.