Treat the environment during webpack build as browser rather than node #61
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #47
I need some help to set up tests for this. I was unable to run the tests locally, since on my local machine, I have installed neither grunt nor python (required for the npm package sleep, which is an optional dependency of karma-xvfb-chrome-launcher) nor java (required for mockserver) nor Chrome (I am running on Ubuntu). Rather, I use all those only in Docker containers when necessary.
I think a useful testing setup would require a new grunt task, like the ones you have set up for node and browser modes. We could take the easy way out and just copy the browser tests and define a global
require
mock before the tests. Or we could do it the completely correct way and somehow set up a Webpack environment within the tests, similar to how you start an entire browser for the browser tests. Both of these options go a little far given the superficial knowledge I have about this package's structure and build process.