Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make react-native-root-siblings peerDependence #9

Closed
wants to merge 1 commit into from

Conversation

taoqf
Copy link

@taoqf taoqf commented Sep 24, 2019

@mochixuan
Copy link
Owner

No problems found, can you talk about Chinese in general?

@taoqf
Copy link
Author

taoqf commented Sep 25, 2019

@mochixuan react-native-root-siblings 存在一个全局的注册 https://github.com/magicismight/react-native-root-siblings/blob/master/index.js#L39 如果一个项目下存在多个版本的react-native-root-siblings,就会有问题.

@mochixuan
Copy link
Owner

哦,大致明白了,我现在换成了最新版的,应该没问题了吧

@taoqf
Copy link
Author

taoqf commented Sep 25, 2019

但不是根本的解决办法,存在2种情况:

  1. 你这个库维护依赖跟不上react-native-root-siblings主版本号.
  2. 你不能排除别人不升级react-native-root-siblings,还使用1.x版本或是某个固定版本的情况.

@mochixuan
Copy link
Owner

好的,谢谢指点。

@mochixuan mochixuan closed this Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants