Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: error naming unification to err #5260

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

chore: error naming unification to err #5260

wants to merge 1 commit into from
+6 −6

Conversation

wnghdcjfe
Copy link
Contributor

@wnghdcjfe wnghdcjfe commented Nov 17, 2024 •
edited
Loading

PR Checklist

closed #5258

JoshuaKGoldberg
JoshuaKGoldberg reviewed Nov 17, 2024
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable, but we'll want to figure out which name we go with before making a full change. Switching to draft in the meantime. Thanks for starting this!

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as draft November 17, 2024 16:47
@wnghdcjfe
Copy link
Contributor Author

First of all, thank you for your review. Everything else is err, but only that part is e, so I don't think it's a little neat lol. I also have no disagreement with being drafted. Thank you. @JoshuaKGoldberg

@JoshuaKGoldberg JoshuaKGoldberg changed the title feat: Error naming unification #5258 chore: error naming unification to err Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🚀 Feature: Error naming unification
2 participants
@wnghdcjfe @JoshuaKGoldberg