Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix test link in html reporter #5224

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

danny0838
Copy link
Contributor

PR Checklist

Overview

Fix as mentioned in the related issue comment.

Copy link

linux-foundation-easycla bot commented Oct 11, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: danny0838 / name: Danny Lin (92af340)

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Just one style nit, but nothing functionally blocking. 🚀

Will leave open for a bit in case anybody from @mochajs/maintenance-crew wants to take a look.

lib/reporters/html.js Outdated Show resolved Hide resolved
@JoshuaKGoldberg
Copy link
Member

Oh, and - please sign the CLA so we can accept this @danny0838.

- `grep` may not work as expected if a previous `fgrep` or `invert` parameter exists.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug: test links in the browser reporter keep the original fgrep and invert params
2 participants