Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make release-please build work #5194

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Conversation

voxpelli
Copy link
Member

@voxpelli voxpelli commented Aug 9, 2024

Follow up to #5186 / #5189. prepublishOnly ran testwhich ran the test-browser which tried to run saucelabs tests and that made the build fail and the release not happen.

This removes it the tests, those are handled in other GitHub Action jobs.

@voxpelli voxpelli added the type: bug a defect, confirmed by a maintainer label Aug 9, 2024
@voxpelli voxpelli requested a review from a team August 9, 2024 10:57
@voxpelli voxpelli self-assigned this Aug 9, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide. We are closing this pull request for now but you can update the pull request description and reopen the pull request.
The check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

@voxpelli voxpelli merged commit afd66ef into main Aug 9, 2024
13 of 14 checks passed
@voxpelli voxpelli deleted the make-release-please-build-work branch August 9, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug a defect, confirmed by a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant