-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: support canonical module #4888
Conversation
This PR hasn't had any recent activity, and I'm labeling it |
Still an active issue |
This PR hasn't had any recent activity, and I'm labeling it |
Bump |
This PR hasn't had any recent activity, and I'm labeling it |
Sure, from what I can tell the commit is easily merged with latest mainline, and the solution should still be the same. I have updated the branch, but don't believe I have power to re-open this PR. Opened a new PR with the same commits (rebased off master): #5040 |
Description of the Change
Handle canonicalizing
Module
, prevent implicit stringification failuresAlternate Designs
canonicalType
return'object'
for modules (not chosen as that could be breaking, not sure...)'module'
fallthrough to'object'
with no custom logic (not chosen so we can indicate different between "object" and "module")Why should this be in core?
Current module canonicalization is broken, see #4887
Benefits
Tests can properly handle errors with a Module inside
Possible Drawbacks
Small chance there is some internal/custom handling expecting canonicalization of modules to fail... Seems unlikely?
Applicable issues
Fixes #4887
Bug fix, patch release