Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update Code of Conduct governance document link in CODE_OF_CONDUCT.md #4405

Merged
merged 1 commit into from
Aug 18, 2020

Conversation

sujin-park
Copy link
Contributor

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions.

Description of the Change

"Code of conduct governance" text and link seem to be connected incorrectly. It has been updated.

Before: https://github.com/openjs-foundation/bootstrap/blob/master/proposals/stage-1/CODE_OF_CONDUCT/FOUNDATION_CODE_OF_CONDUCT_REQUIREMENTS.md

After: https://github.com/openjs-foundation/cross-project-council/blob/master/FOUNDATION_CODE_OF_CONDUCT_REQUIREMENTS.md

Alternate Designs

N/A

Why should this be in core?

N/A

Benefits

People will be able to click on the links, and get to the content they expected.

Possible Drawbacks

N/A

Applicable issues

N/A

@jsf-clabot
Copy link

jsf-clabot commented Aug 12, 2020

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) to 93.849% when pulling ccd2244 on sujin-park:fix-coc-document-link into 78d979d on mochajs:master.

@outsideris outsideris added the area: documentation anything involving docs or mochajs.org label Aug 18, 2020
Copy link
Contributor

@outsideris outsideris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@outsideris outsideris merged commit 16d4f3a into mochajs:master Aug 18, 2020
@boneskull boneskull added this to the next milestone Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: documentation anything involving docs or mochajs.org
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants