Improve image loading behaviors #4295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing animation that doesn't wait for all images. Progressive enhanced
boneskull
approved these changes
May 20, 2020
| await Promise.all( | ||
| supporters.sponsors.map(async sponsor => { | ||
| for await (const chunk of needle.get(sponsor.avatar)) { | ||
| sponsor.dimensions = imageSize(chunk); |
There was a problem hiding this comment.
nice. yeah, they come down with a fixed height, but we don't know the width.
There was a problem hiding this comment.
Yup. HAving the width makes all the difference for being able to have the browser finalize the height of the section because it knows what space to reserve
| </ul> | ||
|
|
||
| <script> | ||
| (function() { |
There was a problem hiding this comment.
I assume this still gets squashed in production.
There was a problem hiding this comment.
Actually I'll just need to check up on the bundling there. I'd want this one to actually stay in place and inlined, which gives us the least amount of lag time between rendering the things it works on and initiating the effect it creates
|
feel free to push again to my branch |
|
rather, directly, no need to PR |
craigtaub
added
the
area: website
boneskull
added
the
semver-patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I looked through what we are doing with loading opencollective avatars and found some improvements.