Issue 3689: Refactoring improving encapsulation #4249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
boneskull
suggested changes
Apr 23, 2020
boneskull
approved these changes
Apr 23, 2020
boneskull
added
type: chore
craigtaub
pushed a commit
that referenced
this pull request
May 21, 2020
* add markOnly instance method to test class * add test cases for markOnly method * use markOnly method of test class instead of accessing parent properties method * refactor cases for test markOnly * refactor test class unit test markOnly to exhaustively satisfy Ref: #3689
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Description of the Change
#3689 recommended to enhance encapsulation by introducing an instance method appendOnlyTest to the Suite class. This was already done and merged in #3707 .
Going a step further, the Test class should expose an instance method markOnly() which would do the call on its parent so this is not accessed directly by an other class.
Alternate Designs
Why should this be in core?
Benefits
The Test class handles calls on his own data resulting in a higher degree of abstraction and encapsulation.
Possible Drawbacks
Applicable issues
#3689