chore(ci): Remove PHANTOMJS_CDNURL, nit #3267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems like PHANTOMJS_CDNURL is not needed anymore now that PhantomJS support is [depracated](https://github.com/mochajs/mocha/blob/6a796cbbcd6c9f805e482c424327c82ed0398dbf/CHANGELOG.md#compatibility). Please ignore if I am wrong.
boneskull
added
qa
semver-patch
This was referenced Mar 24, 2018
This was referenced Sep 22, 2018
Closed
Closed
This was referenced Sep 29, 2018
This was referenced Oct 25, 2018
This was referenced Nov 1, 2018
This was referenced Nov 19, 2018
This was referenced Dec 1, 2018
This was referenced Dec 8, 2018
This was referenced Dec 23, 2018
This was referenced Mar 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like
PHANTOMJS_CDNURLis not needed anymore now that PhantomJS support is depracated.Please ignore if I am wrong.
Description of the Change
PHANTOMJS_CDNURLfrom.travis.ymlbecause it is not used anymore.Alternate Designs
Why should this be in core?
Benefits
Possible Drawbacks
Applicable issues