Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set hasOnly to false in _mocha rerun; closes #2429 #2934

Closed
wants to merge 1 commit into from
Closed

Set hasOnly to false in _mocha rerun; closes #2429 #2934

wants to merge 1 commit into from

Conversation

diegobg
Copy link

@diegobg diegobg commented Jul 23, 2017

This is an alternative fix for the --watch with only bug. It's a single line of code and only changes the _mocha script, which doesn't appear to have any unit tests.

@jsf-clabot
Copy link

jsf-clabot commented Jul 23, 2017

CLA assistant check
All committers have signed the CLA.

@ScottFreeCode
Copy link
Contributor

Thanks for taking a shot at this!

In Mocha 4.0 we were able to replace the hasOnly property with a function to ensure the result is always up to date, which should make --watch and only work together correctly. Let us know on #2429 if there are still any issues!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants