Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the security advisory in a non-breaking manner. It upgrades
minimatch
to1.0.0
, basically--but from what I can tell, the only meaningful change from0.3.0
was a feature to support number padding in brace expansion.Generally speaking, what we're doing here should be avoided (forking old versions of modules and re-publishing them under new names). Doing so could potentially expose us to security issues down the road--if an issue is detected in
minimatch
orglob
and subsequently fixed, we will have to manually backport the fix--assuming we even know about any issue!I could go either way here; I can't conceive of a manner in which it would affect users of Mocha via usage of
mocha
itself. This issue does not affect Mocha in the browser.See the forked/renamed modules glob-mocha and minimatch-mocha, the latter of which contains a backport for the advisory fix.
cc @ScottFreeCode