-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump glob patch version to remove warning #2201
Conversation
When installing `[email protected]`, `[email protected]` triggers the following warning: ``` npm WARN deprecated [email protected]: graceful-fs version 3 and before will fail on newer node releases. Please update to graceful-fs@^4.0.0 as soon as possible. ``` This commit bumps to the latest patch version before a major version. Diff at isaacs/node-glob@v3.2.3...v3.2.11.
@graingert, does this apply with this patch bump too (from v3.2.3 to v3.2.11). I was under the impression that the code changes were rather safe, but people say in the comments that if breaks old versions of npm. I thought the breakage was introduced later, in a major version bump. |
@astorije if you want to stay on the safe side use v3.2.6 instead. isaacs/node-glob@v3.2.3...v3.2.6 only seems to include the removal of @danielstjules would that be something you're okay with? |
OK, looks like 3.2.10 is not safe, but 3.2.11 is safe:
Thanks! |
@boneskull @danielstjules any chance of a patch release in the near future including this fix? |
When installing
[email protected]
,[email protected]
triggers the following warning:This commit bumps to the latest patch version before a major version.
Diff at isaacs/node-glob@v3.2.3...v3.2.11.