prevent html reporter updating url hash #2119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Would you mind undoing your changes to mocha.js (we only run make before releases, keeps PR/commit diffs cleaner) and squashing? |
|
sure no problem thanks |
|
Are we ok to merge this? It would help with the filtering of tests for ember-cli projects. Thanks |
|
Thanks @jimenglish81! |
This was referenced Jun 15, 2016
This was referenced Sep 23, 2018
This was referenced Dec 29, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have noticed a small issue with the hash updating when the passed/failure filters are clicked on the html reporter. When testing an app that uses hash navigation this can cause the page to navigate.
Let me know thoughts. Thanks