Strenghten checks across the board for pending/skipped tests or suites #2081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checking for boolean property `.pending` on Test or Suite objects was too brittle in a way that the caller often forgot to check whether any of the object's parents are marked as pending as well. This moves all the pending checks to new `.isPending()` predicate method that is defined on all Suite and Runnable (and thus Test and Hook as well.) Runners and reporters should always use this method to check for "pendingness" of test and suite objects.
Users are supposed to call `this.skip()` from tests and suite hooks, so this is definitely a public API.
|
It works! Thanks! |
|
Awesome! |
|
Thanks for all your help with this @mislav :) |
danielstjules
added a commit
that referenced
this pull request
Feb 17, 2016
Strenghten checks across the board for pending/skipped tests or suites
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking for boolean property
.pendingon Test or Suite objects was too brittle in a way that the caller often forgot to check whether any of the object's parents are marked as pending as well.This moves all the pending checks to new
.isPending()predicate method that is defined on all Suite and Runnable (and thus Test and Hook as well.)Runners and reporters should always use this method to check for "pendingness" of test and suite objects.
Fixes #1760, fixes #1936
/cc @puzrin @danielstjules @Kirill89