Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sure the xunit output dir exists before trying to write to it #1995

Merged
merged 2 commits into from
Dec 9, 2015

Conversation

ianwremmel
Copy link
Contributor

No description provided.

@danielstjules
Copy link
Contributor

Can you take a look at the linting errors?

@danielstjules
Copy link
Contributor

Can you move that logic to _mocha, since it's already responsible for dir creation with browser tests (grep mkdirp to see what I mean)

@ianwremmel
Copy link
Contributor Author

I encountered the problem with grunt-mocha-test. Won't putting the fix in _mocha only help with command line usage while still leaving it broken for programmatic usage?

@danielstjules
Copy link
Contributor

Ah, you're right. Your current approach makes most sense anyway. Thanks!

danielstjules added a commit that referenced this pull request Dec 9, 2015
make sure the xunit output dir exists before trying to write to it
@danielstjules danielstjules merged commit 3af1b8a into mochajs:master Dec 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants