Set safe CSS for progress indicator which does not conflict with Bootstrap #1827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Yeah, we should really better scope those stylings, thanks for pointing it out. |
Might be worth adopting BEM then? Rather than applying small fixes to individual selectors. |
|
any news on this? I just ran into the exact same problem... |
|
Will merge for now, but eventually all mocha CSS should just adopt BEM or a similar convention to avoid these issues. |
danielstjules
added a commit
that referenced
this pull request
Feb 17, 2016
Set safe CSS for progress indicator which does not conflict with Bootstrap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not the best solution for a problem, mocha should not know anything about Bootstrap.
Proposed change would result in less conflicts. However it is made just to get the ball rolling.
In order to prevent such conflicts from happening, it is a good idea to avoid nesting in mochas CSS, e.g. by adapting BEM naming convention (see https://css-tricks.com/bem-101/).
Giving mocha elements classes named
mocha-stats-progresswill eliminate conflicts with other libraries entirely.