-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JSHINT] enabled on project #1534
Conversation
Let's start with default {} .jshintrc and ignore tests for start. to lint: npm run lint
I have added devDependency to JSHint but build failed: can anyone translate from "travis" to "human" for me? thanx... |
You need to make it install a newer |
{ | ||
"laxcomma":true, | ||
"laxbreak":true | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll need to define a proper .jshintrc
, but this is fine for now.
We need to make this part of the |
@ainthek To that end, you'll need to modify |
Thanks for this! |
Chris, actually I can make this directly in package.json, and script:test can run both lint and the tests. Decision is really up to you falks.... |
@ainthek What I'd really like is this to happen:
This gives us the ability to run If you want to skip the linting and just run the tests, |
chris: you have already wrote more lines of the git comments then the actual lines of source code needed to implement this. Why ? I do not get this. PR is proposal. You have minimal work overhead to adjust it and commit in "adjusted work". |
Project maintainers ask submitters of PRs to change the code for a couple reasons:
So, if you are not willing to make the changes, we'll close the issue, make a note in #1359, and someone will get to it eventually. However, I'd like to merge your changes in (with modifications), so I'm asking if you would please change the code and squash your commits. Thanks! |
We actually have an issue discussing that we want to enforce the code style, because it is currently a mess. And it is both easier and faster to make |
Will squash and send again. |
@ainthek ? |
I will work on more complete fix and then make pull request. Will make PR then. |
Follows @boneskull's `make test` suggestion in mochajs#1534 (comment)
Let's start with default {} .jshintrc and ignore tests for start.
to lint:
coding style #1359