fixes for strict mode #1232
Closed
fixes for strict mode #1232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -196,6 +196,7 @@ mocha.ui(program.ui); | |||
|
|
|||
| // load reporter | |||
|
|
|||
| var Reporter; | |||
| try { | |||
| Reporter = require('../lib/reporters/' + program.reporter); | |||
There was a problem hiding this comment.
@csantero rather than confining Reporter to the module scope, it seems you should try removing the var Reporter; statement and adding global.Reporter = require.... instead.
|
needs to be documented here: https://github.com/visionmedia/mocha/blob/master/bin/_mocha#L61..L95 thanks |
|
@travisjeffery Updated. Sorry about the delay. |
|
ah now that i'm trying this, i'm noticing all the code that would have to change - since nested functions would need be declared at the top of their containing function. that goes against our coding style so i don't think this gonna make it. it's a better practice to use |
|
Is this still the case? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple fixes to allow running with --harmony and --use-strict