Fix #1191 - Tests succeed on rejected falsey promises #1224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@domenic why can you reject promises without errors? :( |
|
@jonathanong since rejected promises parallel and are intertwined with thrown errors, they must conform to that contract, which allows anything (even +1 to this PR, by the way. |
jonathanong
added a commit
that referenced
this pull request
Jul 8, 2014
Fix #1191 - Tests succeed on rejected falsey promises
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure that a test case returning a promise fails if the promise is rejected without a reason (or a falsy one).