Add browser script option to package.json #1197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will tell any browserify project to package the browser version of mocha and not the Node version. Fixes issue mochajs#880 This will only cover the JavaScript packaging, CSS is still done manually through <link> tags.
|
Aside: does browserify not work on the non-browser version of mocha? |
|
@jonathanong: Correct the node version uses some packages that are node specific. The browser version has those features removed. The Sinon project has the same problem. |
travisjeffery
added a commit
that referenced
this pull request
May 5, 2014
Add browser script option to package.json
|
I'm still unable to browserify a file that require's mocha. Error:
Anyone else in the same boat? Tried it with node 0.10, 0.12, the latest browserify in npm (11.2.0), the latest mocha in npm (2.3.3). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will tell any browserify project to package the browser version of mocha and not the Node version.
Fixes issue #880
This will only cover the JavaScript packaging, CSS is still done manually through
<link>tags.