Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable global leak check by default #791

Closed
tj opened this issue Apr 2, 2013 · 4 comments
Closed

disable global leak check by default #791

tj opened this issue Apr 2, 2013 · 4 comments
Labels
area: browser browser-specific

Comments

@tj
Copy link
Contributor

tj commented Apr 2, 2013

annoying edge-cases / perf implications
@jfirebaugh
Copy link
Contributor

👍 Konacha already disables it by default.

@tj tj closed this as completed in 868b828 Apr 3, 2013
@gregrperkins
Copy link
Contributor

Is there any discussion of the rationale for this? I'm curious what the perf implications are...

@jfirebaugh
Copy link
Contributor

See here. Rationale was it's a significant performance hit (sorry, don't have exact numbers) and has too high of a false positive rate (was a problem for many konacha users before I defaulted konacha to ignoreLeaks).

@gregrperkins
Copy link
Contributor

Cool, thanks for the info

@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Feb 13, 2024
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: browser browser-specific
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tj @jfirebaugh @gregrperkins