-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace GNU make with something else #2352
Comments
Yeah, I've seen scripty. Pretty different approaches to the problem. I'm bias, but I feel like p-s is better. scripty requires you add a ton of folders and files to your project which is to much work for a simple script IMO. p-s is basically: package.json scripts in a JavaScript file (meaning you get dynamic logic and comments). |
@kentcdodds scripty also has/had that weird win32/linux dichotomy wherein you need to provide two versions of the same script. even if you are using node scripts, you can't use a shebang in windows (afaik!) |
Yeah. Give p-s a try. You'll like it. |
A couple scripty notes:
tl;dr scripty is a tool for writing a project's scripts in first class files (with syntax highlighting, multiple lines, the whole works) with some added understanding of hierarchical grouping of tasks. |
Notes in response to @searls notes 😃
True. And if things get complicated, you can always invoke a stout file yourself (can even be a JavaScript file). Just like with normal npm scripts
That may be true for some teams. But many teams are multiplatform and even more so is open source. p-s has a solid cross-platform story.
That's great and I think it solves that problem really well. My issue is when I'm just calling out to another binary like ESLint or Webpack or AVA, I don't want to have an entire file for a single line to invoke the CLI. I like that p-s gives me the flexibility to both call out to CLIs like this and also really simply break out to a file when necessary. |
Is there a reason why we need to replace GNU Make right now? Also have you considered ShellJS? |
Who said it has to happen right now? 😝 In general, I would prefer to only use Node.js-based tools to maximize portability. ShellJS is cool-- |
If you wanted to use |
I have a branch which starts to leverage It's kind of weird to have both At any rate, if @mochajs/core has any opinion on |
This should come up when I search GitHub issues for "Makefile". [And now it does!] I've mentioned this on Gitter, but I have code prepared that just converts the Makefile targets to NPM scripts and it turned out not that bad. I plan on opening a PR (at which point the whole team can weigh in and evaluate it) after the following are merged as they touch some of the same code:
Now that CI is working again, I am going to try rebasing these as applicable to confirm that the tests pass so we can start merging them. With any luck it'll be fairly clear-cut to finish reviewing any that still need review. |
scripty is a thing and so is p-s.
I don't want the overhead of a full-blown task runner like Grunt or Gulp, as I don't want to rely on plugins.
Thoughts?
@kentcdodds Have you seen scripty? p-s looks similar. Maybe you guys should pool efforts?
cc @searls
cc @mochajs/core
The text was updated successfully, but these errors were encountered: