Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kill diff support #1832

Closed
lydell opened this issue Aug 15, 2015 · 0 comments
Closed

Kill diff support #1832

lydell opened this issue Aug 15, 2015 · 0 comments
Labels
status: waiting for author waiting on response from OP - more information needed

Comments

@lydell
Copy link

lydell commented Aug 15, 2015

In #1071 I requested diff support in the HTML reporter, but it was closed pointing to http://unexpected.js.org/.

In other words, the response was “it’s up to the assertion library”.

At first I thought that was a shame, because it felt like such duplicated effort for each assertion library to implement diffing (of course, every assertion library doesn’t have to do it; some might dislike diffing and consider it a feature, but most, I think, like diffs).

Now I’ve tried Unexpected (see link above) a bit, and boy do I like it! It’s diffs are pure awesomeness! When playing with it I realized that if assertion libraries do diffs themselves they can do it a lot better, since they have access to much more information than mocha. Another example is https://github.com/power-assert-js/power-assert.

mocha’s diffing has been plagued with issues and regressions, and has a bunch of open (and semi-open) issues right now: #1241, #1348, #1624, #1712.

I’d like to open the discussion on removing diffs from mocha entirely, and let it focus on doing what it does well. Leave diffs to the assertion libs which have the possibility to do it better. Just my 2¢.

@drazisil drazisil added status: waiting for author waiting on response from OP - more information needed nice to have enhancement proposal of low priority and removed nice to have enhancement proposal of low priority labels Mar 30, 2017
@lydell lydell closed this as completed Apr 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting for author waiting on response from OP - more information needed
Projects
None yet
Development

No branches or pull requests

2 participants