-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Bug: Diffs no longer show line changes #1712
Comments
No problem. FWIW, I'd prefer to see the strings in style similar to |
This is still the case with 2.3.2: $ cat test.js
var assert = require('assert');
it('test', function() {
var a = '1\n2\n3\n';
var b = '123';
assert.equal(a, b);
});
$ ./bin/mocha test.js
․
0 passing (6ms)
1 failing
1) test:
AssertionError: '1\n2\n3\n' == '123'
+ expected - actual
-1
-2
-3
+123
... cc @mochajs/mocha Any preference here between the two screenshots in the original msg? Is the current output a problem? |
I very much prefer seeing this:
...over seeing this:
The thing I'd consider problematic here is that we can't tell whether there's a trailing newline. What I think we should be seeing is this:
(By extension, two |
not stale |
Update from 2.2.4 to 2.2.5 improved diff color contrast, but lost information on line changes.
Before
After
The text was updated successfully, but these errors were encountered: