make guarantees about orphaned processes

- updates workerpool to v6.0.2, which guarantees child processes exit before `Pool#terminate()` resolves - cleanup `test/integration/options/parallel.spec.js`
mochajs · Oct 9, 2020 · 6ceca82 · 6ceca82
1 parent f24f190
commit 6ceca82
Show file tree

Hide file tree

Showing 4 changed files with 369 additions and 291 deletions.
diff --git a/lib/nodejs/buffered-worker-pool.js b/lib/nodejs/buffered-worker-pool.js
@@ -75,9 +75,7 @@ class BufferedWorkerPool {
       process.execArgv.join(' ')
     );
 
-    this.options = Object.assign({}, WORKER_POOL_DEFAULT_OPTS, opts, {
-      maxWorkers
-    });
+    this.options = {...WORKER_POOL_DEFAULT_OPTS, opts, maxWorkers};
     this._pool = workerpool.pool(WORKER_PATH, this.options);
   }
 

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -73,7 +73,7 @@
     "supports-color": "7.1.0",
     "which": "2.0.2",
     "wide-align": "1.1.3",
-    "workerpool": "6.0.0",
+    "workerpool": "6.0.2",
     "yargs": "13.3.2",
     "yargs-parser": "13.1.2",
     "yargs-unparser": "1.6.1"
@@ -130,6 +130,7 @@
     "needle": "^2.5.0",
     "nps": "^5.10.0",
     "nyc": "^15.1.0",
+    "pidtree": "^0.5.0",
     "prettier": "^1.19.1",
     "remark": "^12.0.1",
     "remark-github": "^9.0.1",