Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[do not merge] Bump golang 1.11beta3 #2692

Closed
wants to merge 3 commits into from

Conversation

thaJeztah
Copy link
Member

based on top of #2689, to make it compile on Go 1.11; let's see what breaks

@thaJeztah thaJeztah changed the title [do not merge] Bump golang 1.11 [do not merge] Bump golang 1.11beta1 Jul 6, 2018
@codecov
Copy link

codecov bot commented Jul 7, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@496d19b). Click here to learn what that means.
The diff coverage is 40%.

@@            Coverage Diff            @@
##             master    #2692   +/-   ##
=========================================
  Coverage          ?   61.99%           
=========================================
  Files             ?      134           
  Lines             ?    21787           
  Branches          ?        0           
=========================================
  Hits              ?    13507           
  Misses            ?     6833           
  Partials          ?     1447

@thaJeztah
Copy link
Member Author

nice! It's green

@thaJeztah thaJeztah changed the title [do not merge] Bump golang 1.11beta1 [do not merge] Bump golang 1.11beta2 Jul 23, 2018
@thaJeztah
Copy link
Member Author

rebased, and updated to Go 1.11beta2

Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah changed the title [do not merge] Bump golang 1.11beta2 [do not merge] Bump golang 1.11beta3 Aug 7, 2018
Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah
Copy link
Member Author

closing, as this was handled through #2752

@thaJeztah thaJeztah closed this Mar 2, 2019
@thaJeztah thaJeztah deleted the bump_golang_1.11 branch March 2, 2019 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant