Network allocator does not respect the IPAM contract for nw gw #2078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Needs to label the request for network gateway address appropriately and needs to honor the case where the driver has autonomously selected the gateway address. Signed-off-by: Alessandro Boch <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2078 +/- ##
=========================================
- Coverage 54.64% 54.3% -0.35%
=========================================
Files 114 111 -3
Lines 19679 19360 -319
=========================================
- Hits 10754 10513 -241
+ Misses 7646 7580 -66
+ Partials 1279 1267 -12Continue to review full report at Codecov.
|
| gwIP.IP = ip | ||
| } | ||
| if ic.Gateway != "" || gwIP == nil { | ||
| gwIP, _, err = ipam.RequestAddress(poolID, net.ParseIP(ic.Gateway), map[string]string{ipamapi.RequestAddressType: netlabel.Gateway}) |
There was a problem hiding this comment.
We're using ic.Gateway here when according to the logic in the if statement above, it could be empty. Is that correct?
There was a problem hiding this comment.
Yes. If user specified a network gateway, (parsed(ic.Gateway)= some ip) we tell IPAM driver to reserve it. If the user did not pass one (parsed(ic.Gateway)=nil), like to tell IPAM driver to chose one by himself.
|
LGTM |
1 similar comment
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
appropriately and needs to honor the case where the
driver has autonomously selected the gateway address.
This was reported in moby/libnetwork/issues/1702