Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.10] vendor: Update go-winio to v0.4.20 #42944

Merged
merged 1 commit into from
Oct 18, 2021

Conversation

kevpar
Copy link
Contributor

@kevpar kevpar commented Oct 15, 2021

Updates go-winio to the latest v0.4.x version. The main important fix
here is to go-winio's backuptar package. This is needed to fix a bug in
sparse file handling in container layers, which was exposed by a recent
change in Windows.

go-winio v0.4.20: https://github.com/microsoft/go-winio/releases/tag/v0.4.20

There is a similar PR to master to update to go-winio v0.5.1 (#42943).
However for 20.10 we need to stay on v0.4.x versions as they avoid a
breaking change.

Signed-off-by: Kevin Parsons [email protected]

Updates go-winio to the latest v0.4.x version. The main important fix
here is to go-winio's backuptar package. This is needed to fix a bug in
sparse file handling in container layers, which was exposed by a recent
change in Windows.

go-winio v0.4.20: https://github.com/microsoft/go-winio/releases/tag/v0.4.20

Signed-off-by: Kevin Parsons <[email protected]>
@kevpar kevpar marked this pull request as ready for review October 15, 2021 22:30
@thaJeztah thaJeztah added this to the 20.10.10 milestone Oct 17, 2021
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Member

@AkihiroSuda @cpuguy83 PTAL

@thaJeztah
Copy link
Member

CI failures are unrelated (tracked through #41930 and #42892)

=== RUN   TestHealthKillContainer
    health_test.go:62: timeout hit after 10s: waiting for container to become healthy
--- FAIL: TestHealthKillContainer (12.43s)

@thaJeztah
Copy link
Member

Bringing this one in

@thaJeztah thaJeztah merged commit 9f5b26f into moby:20.10 Oct 18, 2021
@kevpar
Copy link
Contributor Author

kevpar commented Oct 19, 2021

Somehow missed the emails that this got in. Thanks folks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants