-
Notifications
You must be signed in to change notification settings - Fork 18.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Jenkinsfile #38565
Add Jenkinsfile #38565
Conversation
Nice. Now I "just" need study how to install and configure Jenkins... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 😍
@dave-tucker I ❤️ u ! 🤗
A couple of things to bear in mind 🐻
|
@dave-tucker first of all. Thanks for sharing this config with us. Just to have it visible simplifies many things as we don't need to guess.
I don't know how others want to use this config but I would prefer to move logic to Jenkinsfile to generic bash scripts. First example of that kind of approach is on olljanat@936fc81 On that way:
I have understood that that logic have been in Jenkins on past and it was moved to PowerShell to simplify local debugging (seen comment on some old PR).
Fixed already on example commit above 😉
At least most common flaky issues are listed on #37306 |
Codecov Report
@@ Coverage Diff @@
## master #38565 +/- ##
==========================================
+ Coverage 36.43% 36.44% +<.01%
==========================================
Files 613 613
Lines 45847 46481 +634
==========================================
+ Hits 16706 16941 +235
- Misses 26849 27155 +306
- Partials 2292 2385 +93 |
b12ce9d
to
0e5dd83
Compare
Updated to add a 3 hr timeout to avoid builds staying in a pending state forever. |
@olljanat I like the bash scripts ❤️ |
@dave-tucker - yes, |
0e5dd83
to
7d9748a
Compare
I pushed some changes to add a Now I think this is good to go 🎉 See: https://jenkins.dockerproject.org/job/dave-tucker/job/jenkinsfile-test/ I've seen it pass at least once on each set of tests. |
|
7d9748a
to
1ec7daf
Compare
This commit uses the exitings jenkins freestyle job configuration to create a jenkinsfile. This allows the project to use multi-branch pipelines in Jenkins and to allow others to contribute to the CI setup. Signed-off-by: Dave Tucker <[email protected]>
1ec7daf
to
4d7721c
Compare
Good catch @cpuguy83 - I've just updated this PR to fix that! |
|
Oh, somehow I grabbed logs from an old run... |
Oh well, powerpc has the same error on the last run. Seems to be triggered when a particular pipeline step fails. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Let's merge this; the file won't be used for now, as follow-up changes are needed to change the CI config and so on 😇 |
@cpuguy83 @thaJeztah thanks!
This is a quick fix - I just need to add that method to the whitelist in Jenkins... |
- What I did
This commit uses the existing jenkins freestyle job configuration to
create a jenkinsfile. This allows the project to use multi-branch
pipelines in jenkins and to allow others to contribute to the CI setup.
- How I did it
Copy/Paste 😉
- How to verify it
A test job: https://jenkins.dockerproject.org/job/dave-tucker/job/jenkinsfile-test/
- Description for the changelog
N/A
- A picture of a cute animal (not mandatory but encouraged)